feat(container): pageWidth characteristics on page containers #519
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/pages/PageList.tsx
Outdated
| @@ -14,49 +14,57 @@ export interface IPageMeta { | |||
| title: string | |||
| description: string | |||
| exact?: boolean | |||
| fullPageWidth: boolean | |||
There was a problem hiding this comment.
Should this be optional? (fullPageWidth?:boolean)
I think it's right how the default behaviour is the standard max-width value, and this is essentially an optional override. We could also remove the fullPageWidth: false from any of the how-tos not implementing this feature
chrismclarke
requested changes
Jul 10, 2019
|
@chrismclarke I've pushed the optional change, is this what you meant? |
BenGamma
approved these changes
Jul 11, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not sure if this maps a lot of sense to do it this way, but I can imagine some pages want to have a "cover" format. I'm not sure on the right words to use, or whether you want to achieve it this way, but just an idea. The main use case is for something like Maps where you want it to cover the whole width of the page, and not be boxed into the container size.