Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Module/profile page #520

Merged
merged 39 commits into from
Jul 12, 2019
Merged

Module/profile page #520

merged 39 commits into from
Jul 12, 2019

Conversation

BenGamma
Copy link
Contributor

@BenGamma BenGamma commented Jul 11, 2019

Main work on the profile pages, on track for the v0.5.0 release 🚀

/settings page :

  • I renamed the page /profile into /settings, which is your personal settings page where you can edit your informations.
  • added 2 packages : react-calendar and react-flag-select to help building the form fields.
  • build the frontend based on mockups
  • All the fields are editable and on click on the update button, it updates the profile on firebase aswell.
    Close [page] user Profile #507

/u/username page :

  • based on the :username param in the url, I load the informations from the db
  • build and display the profile informations based on the mockups

TODO before v0.5.0 release

  • merge the branch module/map
  • link the profiles data to the map
  • link/update the map datastructure to the profile. For example now a profile doesn't have a type field (shredder worspace, community builder...)
    and as said in feat/module/map/frontend #517 :
  • Hook up data from firebase (map and pins + filters)
  • Take My Pin button somewhere
  • Debug weird problem where map resets to the center for some odd reason

BenGamma added 30 commits June 14, 2019 11:53
…arPicker & FlagSelector component to form value onSubmit
@BenGamma BenGamma requested a review from chrismclarke July 11, 2019 16:27
Copy link
Member

@chrismclarke chrismclarke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So. Much. Code!!

But it seems in good shape 👍 , nice separation across the various components, helpers etc. There's definitely a lot here and haven't tested extensively, but what I have works as expected and I really like all the small features like adding to the map, social icons, calendar icons, calendar etc., so again really nice one. Marked as approved so merge at will

I've added the following minor commits:

  1. Change user.models.ts to pull timestamp model from a common model instead of firebase. Ideally it would be best to keep any references to firebase in as few places as possible to make it easier to replace in the future, so this is my own fault for doing elsewhere first.

  2. Fix minor error thrown when the user doesn't have a location saved but trying to access user.location.value or user.location.latlng.lat.

@BenGamma BenGamma merged commit 3b4fd4c into master Jul 12, 2019
@BenGamma BenGamma mentioned this pull request Jul 12, 2019
@chrismclarke chrismclarke deleted the module/profile-page branch July 12, 2019 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[page] user Profile
2 participants