-
-
Notifications
You must be signed in to change notification settings - Fork 421
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Module/profile page #520
Module/profile page #520
Conversation
… module/profile-page
…nstead of Selector
…arPicker & FlagSelector component to form value onSubmit
…w react-final-form to read initialValues
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So. Much. Code!!
But it seems in good shape 👍 , nice separation across the various components, helpers etc. There's definitely a lot here and haven't tested extensively, but what I have works as expected and I really like all the small features like adding to the map, social icons, calendar icons, calendar etc., so again really nice one. Marked as approved so merge at will
I've added the following minor commits:
-
Change
user.models.ts
to pull timestamp model from a common model instead of firebase. Ideally it would be best to keep any references to firebase in as few places as possible to make it easier to replace in the future, so this is my own fault for doing elsewhere first. -
Fix minor error thrown when the user doesn't have a location saved but trying to access
user.location.value
oruser.location.latlng.lat
.
Main work on the profile pages, on track for the v0.5.0 release 🚀
/settings
page :/profile
into/settings
, which is your personal settings page where you can edit your informations.Close [page] user Profile #507
/u/username
page :TODO before v0.5.0 release
module/map
and as said in feat/module/map/frontend #517 :