UI changes #544
Merged
UI changes #544
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
paulpichot
commented
Aug 21, 2019
paulpichot
commented
- Added 2 fonts (Varela Round & Inter) and font faces + Font family -> Varela Round in Global body
- Created 2 components : EventCard and HowToCard
- Created Flex that extends Flex rebass with Matthia's Design System titles
- Fixed responsive of how to and image gallery style
- Removed the material UI loading progress and replaced simply by "Loading..."
- Styled the map popup
BenGamma
requested changes
Aug 22, 2019
src/components/Button/index.tsx
Outdated
| } | ||
|
|
||
| export const litleBtn = (props: IBtnProps) => |
There was a problem hiding this comment.
I think you mispel little, you mean littleBtn ?
src/components/Button/index.tsx
Outdated
|
|
||
| // extend to allow any default button props (e.g. onClick) to also be passed | ||
| export interface IBtnProps extends React.ButtonHTMLAttributes<HTMLElement> { | ||
| icon?: keyof IGlyphs | ||
| disabled?: boolean | ||
| litleBtn?: boolean | ||
| mediumBtn?: boolean | ||
| bigBtn?: boolean |
There was a problem hiding this comment.
Instead of adding 3 different props for the button you could add one props size that can take 3 values small | medium | big
See an example here
BenGamma
approved these changes
Aug 23, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.