Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

103 how to edit mode #564

Merged
merged 25 commits into from
Sep 12, 2019
Merged

103 how to edit mode #564

merged 25 commits into from
Sep 12, 2019

Conversation

BenGamma
Copy link
Contributor

@BenGamma BenGamma commented Sep 5, 2019

WIP on the how to edit mode.

Main work done is :

  • create a EditHowto component
  • move howto form from CreateHowTo to a Common folder so it can be used by Create & Edit howto pages
  • add props to howtoForm component : onSubmit(), parentType & formValues
  • inject existing text how-to values from store in the edit form
  • inject cover_image , step images, files and tags to edit form
  • create display mechanism for images

Known todo :

  • show existing files in the files inputs. @chrismclarke do you have an idea of how to do that ? After a quick search I found the custom store section in uppy doc, would be something like that ?
  • allow only creator & admin to modify the how-to
  • prevent when edit, loosing the preLine on howto description and step text block
  • display upload modal or at least any visual feedback from submit
  • redirect to how-to page after upload
  • add breadcrumb on top

Copy link
Member

@chrismclarke chrismclarke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the most part looks good, requested on small change in-line, and will look into the upload files now

@chrismclarke chrismclarke merged commit 5144f2b into v0.6_new_ui_pp Sep 12, 2019
@chrismclarke chrismclarke deleted the 103_how_to_edit_mode branch October 10, 2019 10:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants