Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add profile delete methods and ui #569

Merged
merged 2 commits into from
Sep 12, 2019
Merged

Conversation

chrismclarke
Copy link
Member

Overview
Create a button on the user profile page that allows a user to delete their profile
image

Includes a prompt for user to confirm their password before delete
image
This is mainly because firebase requires reauth for sensitive actions, however probably a good safeguard to ensure a user can't easily be deleted if using a shared computer and forgetting to log out

On click the user is removed from the auth database and profile marked as deleted in the database (with all personal information removed)

Todo

  • delete user avatar if uploaded
  • decide how to handle content attributed to them (e.g. how-tos). Currently all content remains, which is probably preferable
  • show notification on successful delete (some sort of toast most likely)
  • show notification on error (e.g. incorrect pw provided for revalidation
  • handle display of a user profile page that has been deleted (user profile still exists, but only with fields _deleted:true

@BenGamma
Copy link
Contributor

Cool that's a nice GDPR compliant feature ! Thanks for that.
Considering the todo you want to keep going on working on this feature and I'll merge now and we create separated issues for the todos points ?

@chrismclarke
Copy link
Member Author

I'd say merge and track todo items elsewhere (I don't think they're critical). They're listed in the code but could also add to an issue

Copy link
Contributor

@BenGamma BenGamma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool looks good, but can you create issues for the todo ? You can gather a few together but so we keep track of it (and maybe a contributor can take on the task)

@BenGamma BenGamma merged commit 6a953ff into master Sep 12, 2019
@chrismclarke chrismclarke deleted the feat/user-profile-delete branch September 12, 2019 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants