Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#542 - Show form validation to the user #574

Merged
merged 2 commits into from
Sep 12, 2019
Merged

#542 - Show form validation to the user #574

merged 2 commits into from
Sep 12, 2019

Conversation

tudi2d
Copy link
Member

@tudi2d tudi2d commented Sep 12, 2019 •
edited
Loading

  • Add ErrorMessage element
  • Show error on blur
  • Add missing '*' for required form fields

Fixes #542

@tudi2d
- Add ErrorMessage element
a3a0645 
- Show error on blur
- Add missing '*' for required form fields
@tudi2d
Merge remote-tracking branch 'upstream/master' into 542-improve-form-…
ad84d70 
…validation
BenGamma
BenGamma approved these changes Sep 12, 2019
View reviewed changes
Copy link
Contributor

@BenGamma BenGamma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks man, work much appreciated !
To answer on your suggestion I think we'll also provide a validation onClick on publish button, because yes it make sense that user doesn't have to touch every fields to know which are required 😌

@BenGamma BenGamma merged commit e49ba4f into ONEARMY:master Sep 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BenGamma BenGamma BenGamma approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[feature request] improve form validation
2 participants
@tudi2d @BenGamma