Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor/all stores #578

Merged
merged 11 commits into from
Sep 13, 2019
Merged

Refactor/all stores #578

merged 11 commits into from
Sep 13, 2019

Conversation

chrismclarke
Copy link
Member

Additional refactoring to remove direct references to firestore and bring all stores in line with databaseV2 methods.

Main Changes

  • Improve module store and bindings to make db and activeUser available to all child stores (avoid store.rootStore.stores.userStore method previously
  • Change userStore, howToStore, TagsStore, EventStore to use new DB
  • Remove legacy database files

Breaking Changes

  • User profile avatar no longer retrieved from user store but standalone method (still found in same file, but really it's a user util function)

Copy link
Contributor

@BenGamma BenGamma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tidy up much appreciated, makes a lot of sense to me !

// this.setState({ msg: 'Tags Uploaded Successfully' })
// } catch (error) {
// this.setState({ disabled: false, msg: 'Error: See console' })
// }
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this normal ? We'll have to populate the tags once in production (the tag list as been updated in the mocks)

@BenGamma BenGamma merged commit 7bba10b into master Sep 13, 2019
@BenGamma BenGamma deleted the refactor/all-stores branch September 13, 2019 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants