-
-
Notifications
You must be signed in to change notification settings - Fork 423
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor/all stores #578
Refactor/all stores #578
Conversation
…into refactor/all-stores
…into refactor/all-stores
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tidy up much appreciated, makes a lot of sense to me !
// this.setState({ msg: 'Tags Uploaded Successfully' }) | ||
// } catch (error) { | ||
// this.setState({ disabled: false, msg: 'Error: See console' }) | ||
// } | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this normal ? We'll have to populate the tags once in production (the tag list as been updated in the mocks)
Additional refactoring to remove direct references to firestore and bring all stores in line with
databaseV2
methods.Main Changes
db
andactiveUser
available to all child stores (avoidstore.rootStore.stores.userStore
method previouslyBreaking Changes