Set up a new firebase environment for cypress #626
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tmhung88
commented
Oct 8, 2019
| - if [ $REACT_APP_BRANCH != 'production' ]; | ||
| then yarn cy:ci; | ||
| fi | ||
| - yarn cy:run |
There was a problem hiding this comment.
@BenGamma I removed the quick fix because this PR has cypress/app run against the same environment whenever tests are executed
tmhung88
commented
Oct 8, 2019
| } | ||
|
|
||
| const siteVariant = getSiteVariant(branch, e) | ||
|
|
There was a problem hiding this comment.
@BenGamma For every environment, I think, we need to define the site variant as an env variable so that we don't have to if/else on branch which is very error-prone.
tmhung88
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
yarn start:ci. Please note it runs at a different port which is localhost:3456