Fix/646 how to button disable on save and edit test #682
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test summary
Run details
View run in Cypress Dashboard ➡️ Failures
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard |
||||||||||||||||||||||||||||||||||||||
tmhung88
reviewed
Oct 15, 2019
cypress/integration/how_to.spec.ts
Outdated
|
|
||
| describe('[Edit a how-to]', () => { | ||
| it('[By Owner]', () => { | ||
| cy.login('howto_creator@test.com', 'test1234') |
There was a problem hiding this comment.
@chrismclarke The test has 2 issues which depends on another test, create-how-to, and execution order (edit needs to run after create). As a result, it's highly fragile and difficult for new devs to debug when it fails as they have no context.
I put back edit tests for some time because there are 2 questions I haven't addressed
- A test flow for edit
- Reset a specific document to the default state
- Run the edit test
- Verify the change against firestore
- an api to verify if data is updated correctly. I imagine it'd be cy.queryDocuments('some conditions').should('eq', {updated_data})
# Conflicts: # cypress/integration/howto/read.spec.ts # src/pages/Howto/Content/Common/Howto.form.tsx
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #646
Frontend
Tests