Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #627: sort how-tos chronologically #709

Merged
merged 1 commit into from
Oct 21, 2019

Conversation

patyiscoding
Copy link
Member

closes #627

@cypress
Copy link

cypress bot commented Oct 19, 2019



Test summary

21 3 12 0


Run details

Project onearmy-community-platform
Status Failed
Commit 7e26a60
Started Oct 19, 2019 2:26 PM
Ended Oct 19, 2019 2:33 PM
Duration 06:34 💡
OS Linux Ubuntu Linux - 14.04
Browser Electron 61

View run in Cypress Dashboard ➡️


Failures

academy.spec.ts Failed
1 [Academy] > [List instructions] > [By Everyone]
howto/read.spec.ts Failed
1 [How To] > [List how-tos] > [By Everyone]
2 [How To] > [Filter with Tag] > [By Everyone]

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

Copy link
Member

@chrismclarke chrismclarke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm still not sure whether it would be best to sort by created or modified - I'm not sure if every change made should bump it back up to the top of the list, but will leave that for UX team to decide and merge for now as it's definitely and improvement.

@chrismclarke chrismclarke merged commit 1f66ba6 into ONEARMY:master Oct 21, 2019
@patyiscoding patyiscoding deleted the bug-fix branch October 21, 2019 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[bug] display how-to in chronological order
2 participants