Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding zIndex object to theme styling #736

Merged
merged 4 commits into from
Nov 1, 2019
Merged

Adding zIndex object to theme styling #736

merged 4 commits into from
Nov 1, 2019

Conversation

drydenwilliams
Copy link
Contributor

@drydenwilliams drydenwilliams commented Nov 1, 2019 •
edited
Loading

Closes: [#723)

BenGamma
BenGamma reviewed Nov 1, 2019
View reviewed changes
Copy link
Contributor

@BenGamma BenGamma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks I like the approach ! It's so common to mess the z-index up. I appreciate to have them only in one place 👍

src/themes/styled.theme.tsx Outdated Show resolved Hide resolved
BenGamma
BenGamma reviewed Nov 1, 2019
View reviewed changes
src/pages/Howto/Content/Howto/Howto.tsx Outdated
@@ -41,7 +42,7 @@ const MoreBox = styled(Box)`
background-image: url(${WhiteBubble0});
width: 100%;
height: 100%;
z-index: -1;
z-index: ${zIndex.back};
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have an error with the back property, it doesn't exist in the theme. Should I use zIndex.default instead ?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

or behind ?

@BenGamma BenGamma merged commit 02531e4 into master Nov 1, 2019
@BenGamma BenGamma deleted the 723-z-index-constants branch November 1, 2019 17:25
@BenGamma BenGamma mentioned this pull request Nov 7, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BenGamma BenGamma BenGamma left review comments

@chrismclarke chrismclarke Awaiting requested review from chrismclarke

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@drydenwilliams @BenGamma