Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added tests for all focus types #737

Merged
merged 15 commits into from
Nov 5, 2019
Merged

Added tests for all focus types #737

merged 15 commits into from
Nov 5, 2019

Conversation

tmhung88
Copy link
Contributor

@tmhung88 tmhung88 commented Nov 1, 2019

No description provided.

@tmhung88
Copy link
Contributor Author

tmhung88 commented Nov 1, 2019

image

There is something fishy with the travis build server. All tests are fine on my local. Will play around with travis settings tomorrow.

@tmhung88
Merge branch 'master' into settings_test
072bf00 
# Conflicts:
#	cypress/integration/settings/focus_workplace.spec.ts
@tmhung88
Copy link
Contributor Author

tmhung88 commented Nov 1, 2019

Digging into the Travis build log and found this warning
Warning: Possible EventEmitter memory leak detected.

Turned out, it's a Cypress issue happening inside Docker and probably connected to failed tests as some reported
cypress-io/cypress#1305
cypress-io/cypress#2938

@tmhung88 tmhung88 changed the title Verify if all settings changes are persisted in firestore correctly Added tests for all focus types Nov 2, 2019
@chrismclarke chrismclarke self-requested a review November 2, 2019 23:12
@chrismclarke
Copy link
Member

Thanks for taking the time to investigate this further, just let me know when ready for merge

chrismclarke
chrismclarke approved these changes Nov 5, 2019
View reviewed changes
Copy link
Member

@chrismclarke chrismclarke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. There's possibly a couple minor adjustments to the map coming in which could have a small knock-on to settings, but on the looks of it I think all should be fine. Will merge this in now in any case to make it easier to troubleshoot any conflicts if they arise

@chrismclarke chrismclarke merged commit 60a4986 into master Nov 5, 2019
@chrismclarke chrismclarke deleted the settings_test branch November 5, 2019 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chrismclarke chrismclarke chrismclarke approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tmhung88 @chrismclarke