Fix anchoring for custom markers on Settings page #738
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iconAnchor is set so that the marker doesn't float around when zooming in and out. The actual location of the marker is still incorrect by a small amount, however.
|
That is super useless of algolia! Seems to be down to rounding, created a new issue here: |
chrismclarke
approved these changes
Nov 1, 2019
There was a problem hiding this comment.
Thanks for the PR!
I'm guessing for future ref the magic formula is [sizeX/2,sizeY] as coordinates? If you have the chance it might be good to define as variables to avoid the same issue coming up again if anyone wants to change the icons (may be useful to do to have different sizes for different sized cluster icons), but happy to merge this fix for now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous Behaviour
The custom icons float around when the zoom level changes, since the anchoring wasn't correct.
Fix
Changed the anchoring to be in the bottom-centre of the icon so they visually stick to the proper place.
Side note
Interestingly, it turns out that Algolia's places search returns incorrect lat-lng coordinates for some addresses. E.g.
401 West Georgia Street, Vancouveris off by quite a bit. This looks like an issue on Algolia's side. E.g. looking up401 West Georgia Street, Vancouverreturns wrong coordinates on the actual Algolia page, which is strange because they're supposed to be pulling from Open Street Maps, which actually returns the right coordinates. 🤔