Storybook components

[caiokf]

Adding stories for other components on Storybook. Covered in this PR:

• Text
• Heading
• Icon
• EventCard

[cypress]

---

Test summary

30 • 0 • 10 • 0

---

Run details

Project	onearmy-community-platform
Status	Passed
Commit	6c15879
Started	Nov 17, 2019 3:26 PM
Ended	Nov 17, 2019 3:35 PM
Duration	08:45 💡
OS	Linux Ubuntu Linux - 14.04
Browser	Electron 73

View run in Cypress Dashboard ➡️

---

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

[drydenwilliams]

🤔 Not your work but this structure of adding styles seems a bit messy and not super easy to read to me.

[BenGamma]

Yes some components needs refactoring, especially Text I've addressed the issue here #727

[caiokf]

@drydenwilliams
Check this commit and see if this looks a bit better (would look nicer without lint breaking lines, but maybe still ok)

[caiokf]

@BenGamma Please take a look, I managed to include a few more components, although not a comprehensive list yet. There are a few commits that touch some of the component's code, so please check those too.

[BenGamma]

Storybook works like a charm thanks !
But when I'm running yarn start I have a few errors on compile :

• First with a onClick props to change to OnClick, which is quite straightforward.
• The second is about typings (see screenshot or run yarn start to reproduce). Can you resolve before I merge ? Thanks

[caiokf]

@BenGamma Yes, will fix it. But question about the OnClick: is there a reason why it is capitalized? it comes from this commit. Can I make it lowercase everywhere?

Storybook works like a charm thanks !
But when I'm running yarn start I have a few errors on compile :

• First with a onClick props to change to OnClick, which is quite straightforward.
• The second is about typings (see screenshot or run yarn start to reproduce). Can you resolve before I merge ? Thanks

[BenGamma]

@BenGamma Yes, will fix it. But question about the OnClick: is there a reason why it is capitalized? it comes from this commit. Can I make it lowercase everywhere?

Storybook works like a charm thanks !
But when I'm running yarn start I have a few errors on compile :

• First with a onClick props to change to OnClick, which is quite straightforward.
• The second is about typings (see screenshot or run yarn start to reproduce). Can you resolve before I merge ? Thanks

Yes you can lowercase it. It's legacy code, probably a mistake by the time 😇