Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Observe userStore.user to render UI on login #744

Merged
merged 4 commits into from
Nov 5, 2019
Merged

Observe userStore.user to render UI on login #744

merged 4 commits into from
Nov 5, 2019

Conversation

tmhungcode
Copy link
Contributor

@tmhungcode tmhungcode commented Nov 4, 2019 •
edited by chrismclarke
Loading

the cause #692 is we didn't subscribe userStore.user to render on change
closes #692

@tmhungcode tmhungcode mentioned this pull request Nov 4, 2019
Closed
@tmhungcode
Copy link
Contributor Author

@chrismclarke the build passed for this PR. Check out the log https://travis-ci.org/ONEARMY/community-platform/builds/607174874

I don't know why Travis gets stuck at pending

chrismclarke
chrismclarke reviewed Nov 5, 2019
View reviewed changes
Copy link
Member

@chrismclarke chrismclarke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, yes we want to be observing user changes. As mentioned in slack, this can still be done directly from the howtoStore.activeUser property (which wraps the user store user), will add a commit to tidy

chrismclarke
chrismclarke approved these changes Nov 5, 2019
View reviewed changes
Copy link
Member

@chrismclarke chrismclarke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

had a minor conflict to resolve but should all be good now with the minor stores update. Thanks again for working this out.

@chrismclarke chrismclarke merged commit d8b5d75 into master Nov 5, 2019
@chrismclarke chrismclarke deleted the fix_692 branch November 5, 2019 17:06
@tmhungcode tmhungcode mentioned this pull request Nov 5, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chrismclarke chrismclarke chrismclarke approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Edit button is not shown after login with firebase api
2 participants
@tmhungcode @chrismclarke