731 display validations errors on click #745
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… validation errors on DatePicker field - small css fix
chrismclarke
approved these changes
Nov 5, 2019
There was a problem hiding this comment.
I tested with the settings page and worked really nicely. It might be worth double-checking existing tests with the new changes (I know some looked for button validation states). Hopefully by tomorrow the full test suite should be back up and running to make this process easier, but for now happy to merge and then troubleshoot after.
|
Yeah I agree with the test but we'll troubleshoot soon after v0.8 release. I'll deactivate them for now to allow build on |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix
FieldArray) needs a bit of work to be totally stable.Added
/how-to/create,event/createand your profile/settingspage to see the validation errors. I did a lot of refactoring on the form components (SelectField,LocationField, etc..). Closes display errors on fields on save click #731Known issues
When editing your profile settings there is some conflicts between the values from react-final-form and the state
customFieldValues. Working on a fix now.