Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #734: added a warning about unsaved changes #758

Merged
merged 7 commits into from
Nov 11, 2019

Conversation

patyiscoding
Copy link
Member

closes #734

@BenGamma
Copy link
Contributor

BenGamma commented Nov 7, 2019

Nice one with the message ! I'll fix the conflicts myself and will merge. Thanks 🙌

@patyiscoding
Copy link
Member Author

patyiscoding commented Nov 7, 2019

@BenGamma I think there's a problem though, as it was based on the solution I wanted to merge for #757 from 307dd32 😂 The Prompt here depends on the upload status of how-tos and it has to be reset somewhere. That's also why the upload status panel in #757 was showing up.

@patyiscoding
Copy link
Member Author

ok, I added the reset next to the changes from your 6a0da09 solution, should work now 👌

@cypress
Copy link

cypress bot commented Nov 7, 2019



Test summary

28 2 10 0


Run details

Project onearmy-community-platform
Status Failed
Commit 869dec8
Started Nov 11, 2019 10:23 AM
Ended Nov 11, 2019 10:33 AM
Duration 10:06 💡
OS Linux Ubuntu Linux - 14.04
Browser Electron 73

View run in Cypress Dashboard ➡️


Failures

cypress/integration/events.spec.ts Failed
1 [Events] > [List events] > [By Everyone]
2 [Events] > [Filter Events] > [By Everyone]

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

/>
)}
<Prompt
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool component, didn't know about this 👍

@BenGamma
Copy link
Contributor

Thanks ! Nice and easy.
In an ideal world we would display the Prompt only if the form values have changed, but that's less urgent. The important thing is that the values that the user entered in his how-to doesn't disapear in case of wrong manipulation.
I created a separate issue for that later #766

@BenGamma BenGamma merged commit d66d90a into master Nov 11, 2019
@BenGamma BenGamma deleted the 734-warning-onpageleave branch November 11, 2019 11:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[feature request] warn user if leave page without saving
3 participants