-
-
Notifications
You must be signed in to change notification settings - Fork 407
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
User badge fallback image #782
Conversation
Test summaryRun details
View run in Cypress Dashboard ➡️ FailuresThis comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard |
I like that you separated the code to get workspace type in a dedicated file. It improve clarity. I added a small commit to remove a deprecated way of getting an avatar picture. You couldn't know, it's part of a little bit of legacy code. Thanks for the work @lauvrenn 💪 |
closes #775
I added the fallback image and restructured the way workspace icons are retrieved. This way, the non-decorated icons are no longer based in components related to the map, which makes choosing between the two types of workspace icons in other parts of the app easier.