Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

User badge fallback image #782

Merged
merged 5 commits into from
Nov 22, 2019
Merged

User badge fallback image #782

merged 5 commits into from
Nov 22, 2019

Conversation

patyiscoding
Copy link
Member

closes #775
I added the fallback image and restructured the way workspace icons are retrieved. This way, the non-decorated icons are no longer based in components related to the map, which makes choosing between the two types of workspace icons in other parts of the app easier.

@patyiscoding patyiscoding added the Review: Assigned 👉 Waiting on review from a specific dev label Nov 17, 2019
@cypress
Copy link

cypress bot commented Nov 17, 2019



Test summary

24 6 10 0


Run details

Project onearmy-community-platform
Status Failed
Commit b91178a
Started Nov 22, 2019 5:15 PM
Ended Nov 22, 2019 5:27 PM
Duration 12:36 💡
OS Linux Ubuntu Linux - 14.04
Browser Electron 73

View run in Cypress Dashboard ➡️


Failures

common.spec.ts Failed
1 [Common] > [User Menu] > [By Authenticated]
settings.spec.ts Failed
1 [Settings] > [Focus Workplace] > [Editing a new Profile]
2 [Settings] > [Focus Member] > [Edit a new profile]
3 [Settings] > [Focus Machine Builder] > [Edit a new profile]
4 [Settings] > [Focus Community Builder] > [Edit a new profile]
5 [Settings] > Focus Plastic Collection Point > [Edit a new profile]

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

@BenGamma
Copy link
Contributor

I like that you separated the code to get workspace type in a dedicated file. It improve clarity.

I added a small commit to remove a deprecated way of getting an avatar picture. You couldn't know, it's part of a little bit of legacy code.
Now the badge is the main avatar image, not the fallback.

Thanks for the work @lauvrenn 💪

@BenGamma BenGamma merged commit ac77eef into master Nov 22, 2019
@BenGamma BenGamma deleted the 775-display-user-badge branch November 22, 2019 17:15
@BenGamma BenGamma mentioned this pull request Nov 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Review: Assigned 👉 Waiting on review from a specific dev
Projects
None yet
Development

Successfully merging this pull request may close these issues.

display user badge in header
3 participants