Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set link size to fit content #786

Closed
wants to merge 3 commits into from

Conversation

benjdelt
Copy link
Contributor

@benjdelt benjdelt commented Nov 20, 2019

Closes #779 I set the Link's width to 300px to match the FileDetails component (which is already set to 300px).

@cypress
Copy link

cypress bot commented Nov 20, 2019



Test summary

30 0 10 0


Run details

Project onearmy-community-platform
Status Passed
Commit fc74841
Started Nov 20, 2019 4:11 AM
Ended Nov 20, 2019 4:19 AM
Duration 08:08 💡
OS Linux Ubuntu Linux - 14.04
Browser Electron 73

View run in Cypress Dashboard ➡️


This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

@benjdelt benjdelt changed the title Set link size to fit content, changed a tag to link component Set link size to fit content Nov 20, 2019
href={meta.downloadUrl}
target="_blank"
download={file.name}
style={{ width: '300px' }}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤔 inline style, can we wrap this and use a styled-component?

@BenGamma
Copy link
Contributor

Merge with #793

@BenGamma BenGamma closed this Nov 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[bug] how-to files button fit content
3 participants