Fixed howto submit after deleting step image

[benjdelt]

Fix for #756 I found the problem. In howto.store.tsx, line 129, when an image is deleted, the object in the stepImages variable is set to null, then that array gets iterated on in uploadCollectionBatch() and the function tries to access properties on null. I added a filter to remove falsey values from the stepImages array. As I’m not very familiar with the codebase yet, I am open to suggestions as to solve this differently if there is a better way.

[cypress]

---

Test summary

30 • 0 • 10 • 0

---

Run details

Project	onearmy-community-platform
Status	Passed
Commit	cd82c36
Started	Dec 1, 2019 11:31 PM
Ended	Dec 1, 2019 11:38 PM
Duration	07:17 💡
OS	Linux Ubuntu Linux - 14.04
Browser	Electron 73

View run in Cypress Dashboard ➡️

---

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

[BenGamma]

Yep I like the check with the double exclamation point, it's a better approach than with the shift() method. If I understand well is to be sure that the value returned will be boolean ?

[benjdelt]

Yep I like the check with the double exclamation point, it's a better approach than with the shift() method. If I understand well is to be sure that the value returned will be boolean ?

Yes, the double exclamation point forces the value into a boolean and the filter function removes false values from the array, preventing the uploadCollectionBatch function to call properties on them. As every remaining image data is an object inside the array, they can never be falsey and they can never be filtered out. Only the deleted images will be filtered out.

[BenGamma]

Alright thanks for clarity, that seems like a good option 💪

[benjdelt]

Alright thanks for clarity, that seems like a good option 💪

Thanks, @BenGamma !