-
-
Notifications
You must be signed in to change notification settings - Fork 407
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Db updates v3 #853
Merged
Merged
Db updates v3 #853
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BenGamma
requested changes
Jan 6, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks chris, overall migration script looks good to me. A few questions though :
- So if I understand well
userName
will now be the value we use as slug ?
I pushed a fix for the settings page in case the user modify his name. It was modifyinguserName
, now I set to updatedisplayName
.
Also in the map we use the pin._id to open a pin from url/map#pin_id
(see here for code reference) which was based onv2
userName, seems like we need to update the value of the_id
field ofv3_mappins
with the newly formated slug v3userName
. Could you update the migration script ? - Are we sure that we will not encounter similar
userName
after running the script ?
I'll have a closer look at the tests tomorrow to try to fix them.
Other than that we are very close to release !
Update:
|
BenGamma
approved these changes
Jan 6, 2020
This was referenced Jan 6, 2020
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Large update to update database.
Included:
Database
Add endpoints for
v3_
referencesFunctions
Users
displayName
property to usersTests
v2_
references tov3_
referencesTodo
v3
data already migrated in dev database)Future
v2_
/v3_
references to a single prefix variable for easier changing in the future