add catch to cachDB fallback, defer admin store init #877
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test summary
Run details
View run in Cypress Dashboard ➡️ This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard |
BenGamma
approved these changes
Jan 16, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The added cache fallback methods from PR #872 produced errors when queries were executed on the cache that either:
a) Didn't have a corresponding operation. Basic queries have been created for things like
>,==,<, however the firebase customarray-containsquery has not been created and was throwing an error. This message has been made more clear, and a better catch used to avoid.b) Didn't have indexes on the fields required to query. By default any searches on dexie can only be performed on fields that are specified in the schema, which didn't include things like
userRolesor_authID. This again is now handled more gracefully.Additionally, both errors were being thrown on launch from the admin store. As the admin store isn't required for most users I've changed the init function to only fire on admin page load.
Hopefully this should pass the tests, and if so a new PR might need to be made to production (or can try merge and see if it builds)