Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/email automation #893

Merged
merged 7 commits into from
Mar 11, 2020
Merged

Feat/email automation #893

merged 7 commits into from
Mar 11, 2020

Conversation

chrismclarke
Copy link
Member

NOTE - This PR builds on top of #889 and should only be merged after.
closes #890

Done

Screenshots

image
Example email sent to notify of profile change

Includes note at bottom to suggest viewing at http://www.jsondiff.com to allow easier visualisation of difference

image
Differences viewed at jsondiff

Todo

  • The test notification system has been configured to send me an email when the PP profile is edited, so once in production it would be good to make a small test to confirm
  • Communicate with core team to see how else automated email notifications could/should be used (e.g. custom sign-up confirmation templates etc.)

@cypress
Copy link

cypress bot commented Feb 25, 2020



Test summary

30 0 0 0


Run details

Project onearmy-community-platform
Status Passed
Commit c852fa5 ℹ️
Started Feb 25, 2020 3:03 PM
Ended Feb 25, 2020 3:10 PM
Duration 07:12 💡
OS Linux Ubuntu Linux - 14.04
Browser Electron 78

View run in Cypress Dashboard ➡️


This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

@BenGamma
Copy link
Contributor

Looks good to me, althought if I understand well this PR is only for debuging purpose of the profile wipe bug ?

@chrismclarke
Copy link
Member Author

No it's also to put in an automated email system. We had wanted one a while back to send out custom emails on user signup but didn't have the time to put it together. So now this PR includes one, which I'm using mostly as a demo with the profile wipe bug.

}
}
}

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This could probably be separated in a draft PR for more clarity

@BenGamma
Copy link
Contributor

BenGamma commented Mar 6, 2020

Should I merge now or you are still working on this PR @chrismclarke ?

@BenGamma
Copy link
Contributor

BenGamma commented Mar 11, 2020

I'm merging because the build is failing in dev env and so probably in production too (functions are missing n the local codebase).
Nothing seems too critical with this PR, and it adds a few improvements we will benefit to merge anyway.

@BenGamma BenGamma merged commit 14df77e into master Mar 11, 2020
@BenGamma BenGamma deleted the feat/email-automation branch March 11, 2020 12:21
@BenGamma BenGamma mentioned this pull request Mar 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[feature request] - Email System
2 participants