-
-
Notifications
You must be signed in to change notification settings - Fork 407
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/email automation #893
Conversation
Test summaryRun details
View run in Cypress Dashboard ➡️ This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard |
Looks good to me, althought if I understand well this PR is only for debuging purpose of the profile wipe bug ? |
No it's also to put in an automated email system. We had wanted one a while back to send out custom emails on user signup but didn't have the time to put it together. So now this PR includes one, which I'm using mostly as a demo with the profile wipe bug. |
} | ||
} | ||
} | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This could probably be separated in a draft PR for more clarity
Should I merge now or you are still working on this PR @chrismclarke ? |
I'm merging because the build is failing in dev env and so probably in production too (functions are missing n the local codebase). |
NOTE - This PR builds on top of #889 and should only be merged after.
closes #890
Done
Screenshots
Example email sent to notify of profile change
Includes note at bottom to suggest viewing at http://www.jsondiff.com to allow easier visualisation of difference
Differences viewed at jsondiff
Todo