Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

925 character limits #929

Merged
merged 3 commits into from
Mar 31, 2020
Merged

925 character limits #929

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4f78ed4
Set character limits for user input fields
tudi2d Mar 30, 2020
b0ec80c
invert intro description & how to step maxLength value
BenGamma Mar 31, 2020
9197bd5
Merge branch 'master' into 925-character-limits
BenGamma Mar 31, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/components/Tags/TagsSelect.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -137,5 +137,5 @@ TagsSelect.defaultProps = {
value: {},
category: undefined,
styleVariant: 'selector',
placeholder: 'Select tags - 4 maximum',
placeholder: 'Select tags (max 4)',
}
3 changes: 2 additions & 1 deletion src/pages/Events/Content/EventsCreate/EventsCreate.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -159,7 +159,8 @@ export class EventsCreate extends React.Component<IProps, IState> {
validate={value => this.validateTitle(value)}
validateFields={[]}
component={InputField}
placeholder="Title of your event"
maxLength="140"
placeholder="Title of your event (max 140 characters)"
/>
</Flex>
<Flex
Expand Down
15 changes: 7 additions & 8 deletions src/pages/Howto/Content/Common/Howto.form.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -229,14 +229,12 @@ export class HowtoForm extends React.Component<IProps, IState> {
: false
}
component={InputField}
placeholder="Make a chair from...
"
maxLength="50"
placeholder="Make a chair from.. (max 50 characters)"
/>
</Flex>
<Flex flexDirection={'column'} mb={3}>
<Label>
Select tags for your How-to (max 4) *
</Label>
<Label>Select tags for your How-to*</Label>
<Field
name="tags"
component={TagsSelectField}
Expand All @@ -255,7 +253,7 @@ export class HowtoForm extends React.Component<IProps, IState> {
options={TIME_OPTIONS}
component={SelectField}
data-cy="time-select"
placeholder="How much time? *"
placeholder="How much time?"
/>
</Flex>
<Flex flexDirection={'column'} mb={3}>
Expand All @@ -271,7 +269,7 @@ export class HowtoForm extends React.Component<IProps, IState> {
validateFields={[]}
component={SelectField}
options={DIFFICULTY_OPTIONS}
placeholder="How hard is it? *"
placeholder="How hard is it?"
/>
</Flex>
<Flex flexDirection={'column'} mb={3}>
Expand All @@ -290,7 +288,8 @@ export class HowtoForm extends React.Component<IProps, IState> {
flex: 1,
minHeight: '150px',
}}
placeholder="Introduction to your How-To, keep it to 100 words please! *"
maxLength="400"
placeholder="Introduction to your How-To (max 400 characters)"
/>
</Flex>
<Label htmlFor="description">
Expand Down
6 changes: 4 additions & 2 deletions src/pages/Howto/Content/Common/HowtoStep.form.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,7 +111,8 @@ class HowtoStep extends Component<IProps, IState> {
name={`${step}.title`}
data-cy="step-title"
component={InputField}
placeholder="Title of this step"
placeholder="Title of this step (max 30 characters)"
maxLength="30"
validate={required}
validateFields={[]}
/>
Expand All @@ -120,7 +121,8 @@ class HowtoStep extends Component<IProps, IState> {
<Label htmlFor={`${step}.text`}>Description of this step *</Label>
<Field
name={`${step}.text`}
placeholder="Description of this step"
placeholder="Explain what you are doing in this step. if it gets to long break it into 2 steps (max 700 characters)"
maxLength="700"
data-cy="step-description"
component={TextAreaField}
style={{ resize: 'vertical', height: '300px' }}
Expand Down