-
-
Notifications
You must be signed in to change notification settings - Fork 407
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Virtual scroll code tidying #969
Conversation
…into 493/virtual-scroll
…into 493/virtual-scroll
Test summaryRun details
View run in Cypress Dashboard ➡️ This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Logic wise looks good to me, thanks for the little code tyding @chrismclarke !
One little thing though is the number of howto cards per row. On my screen on desktop I have 4 cards (see screenshot), when we should have at maximum 3 howTo cards in one row, can you have a look at this ?
rowHeight={410} | ||
overscanRowCount={2} | ||
rowRenderer={data => |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here is there a way we use the onResize prop to update the width of the filteredHowToRow
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, yeah I've actually done that locally but forgot to push. I might add a couple more commits and re-request
Ok, so updated:
|
PR Type
PR Checklist
master
branch mergedDescription
Following #962 (thanks @tudi2d!), some minor code tidying
Screenshots/Videos
Probably deserves one as really neat how images now only load in as they scrolled past!