Fix links validations

[BenGamma]

PR Type

• [ x ] Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change)

PR Checklist

• - Latest master branch merged
• - PR title descriptive (can be used in release notes)
• - Passes Tests

Description

• remove link validation for discord IDs
• As described in fix profile double type and links bugs, tidy profile code #970 thread, still one little bug to fix :

I've spotted a weird behavior in the link validation while doing a last check. See a screencast here
It happend in the case you have an invalid url first, then the validation removes the last char of the input. But I don't get it because we are not striping any character, we are just adding from the existing value 🤔

[cypress]

---

Test summary

60 • 0 • 0 • 0

---

Run details

Project	onearmy-community-platform
Status	Passed
Commit	a5b7e72 ℹ️
Started	Jun 9, 2020 10:56 AM
Ended	Jun 9, 2020 11:00 AM
Duration	04:27 💡
OS	Linux Ubuntu Linux - 16.04
Browser	Multiple

View run in Cypress Dashboard ➡️

---

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

[BenGamma]

The bug seems to come from the url validation validate={value => this.validateDependingOnType(value)}. But it's very weird, sometimes it append, sometimes not. Can you let me know if you can reproduce @chrismclarke ?

[chrismclarke]

I tried copying the steps exactly but can't recreate on my local browsers, so I think perhaps we can just put this down to a browser quirk and assume if it comes up again the user will be able to resolve themselves. Will merge the discord change