649 login friendly messages

[jxofficial]

PR Type

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change)

PR Checklist

• - Latest master branch merged
• - PR title descriptive (can be used in release notes)
• - Passes Tests

Description

Provide friendly messages for failed login.
If email provided is invalid, error message "No account found, typo maybe?" is displayed.
If password provided is invalid, error message "Password does not match the user account" is displayed.

Git Issues

Closes #649

[cypress]

---

Test summary

60 • 0 • 0 • 0

---

Run details

Project	onearmy-community-platform
Status	Passed
Commit	4e63efb ℹ️
Started	Jul 11, 2020 10:35 AM
Ended	Jul 11, 2020 10:40 AM
Duration	04:34 💡
OS	Linux Ubuntu Linux - 16.04
Browser	Multiple

View run in Cypress Dashboard ➡️

---

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

[BenGamma]

Looks good to me !
I'm asking quick review from @chrismclarke as he was the one following up the issue.

[jxofficial]

Thanks for the update!

In the meantime, I have gone ahead and merged the latest master branch before the final review.

[chrismclarke]

Sorry, didn't realise this one is waiting on me. I can see the changes are fairly straight-forward (adding the extra message and profile component bindings). I notice that you have also refactored the messages to a separate utils file, I'm happy that it isn't within the component although thinking about it I think it would make more sense to be in some form of standalone file to make it easier to change, add to or translate in the future (e.g utils/strings.ts or similar). But for now I'd say good to merge and we can worry about the rest later.