Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added UI changes to Map page (issue #965) #998

Merged
merged 6 commits into from
Jul 21, 2020

Conversation

Daniel-Davies
Copy link
Contributor

PR Type

  • [X ] New feature (non-breaking change which adds functionality)

PR Checklist

  • [ X] - Latest master branch merged
  • [ X] - PR title descriptive (can be used in release notes)
  • [ X] - Passes Tests

Description

This PR makes the 6 changes listed in issue 965:

  • Dropdown arrow has been replaced by custom SVG
  • Text placeholders have been made black
  • "Workspaces" => "All Workspaces" (Desktop and Mobile)
  • Smaller check marks (20x20) on dropdown selection
  • Dropdowns are styled consistently with other Select components
  • Pointer has been made type: cursor

Mainly this has just changed little sections of the existing codebase; one hack did need to be use when changing the placeholder text color. Since the input to the Styled Components (Input) is entered dynamically, there is no way to succeessfully pass in the '::placeholder' selector. I therefore needed to create a new styled component (BlackPlaceholderInput) rather than extending the old one with a custom style.

Git Issues

_Closes #965

Screenshots/Videos

@cypress
Copy link

cypress bot commented Jul 16, 2020



Test summary

60 0 0 0


Run details

Project onearmy-community-platform
Status Passed
Commit cf0222f ℹ️
Started Jul 16, 2020 10:39 AM
Ended Jul 16, 2020 10:45 AM
Duration 05:03 💡
OS Linux Ubuntu Linux - 16.04
Browser Multiple

View run in Cypress Dashboard ➡️


This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

@BenGamma
Copy link
Contributor

Thanks @Daniel-Davies for the work !
I liked the little style variant for the map dropdown, clever :)

@BenGamma BenGamma merged commit 1ec10da into ONEARMY:master Jul 21, 2020
@BenGamma BenGamma mentioned this pull request Sep 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants