Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add functional tests for docs #437

Merged
merged 6 commits into from
Dec 20, 2021
Merged

Add functional tests for docs #437

merged 6 commits into from
Dec 20, 2021

Conversation

askonev
Copy link
Member

@askonev askonev commented Dec 20, 2021

Add:

  1. rtf_to_docx
  2. odt_to_docx
  3. docx_to_rtf
  4. docx_to_odt

@askonev askonev requested review from ShockwaveNN and l8556 December 20, 2021 11:53
ShockwaveNN
ShockwaveNN approved these changes Dec 20, 2021
View reviewed changes
spec/functional/documents/doc_to_docx_functional_spec.rb
@@ -22,7 +22,7 @@
end
end
after do |example|
FileHelper.clear_dir('files_rmp')
FileHelper.clear_dir('files_tmp')
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe extract FileHelper.clear_dir('files_tmp') to

def self.clear_temp_dir 
FileHelper.clear_dir('files_tmp')
end

In another PR's?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Create issue
#438

@askonev askonev merged commit 597cac7 into master Dec 20, 2021
@askonev askonev deleted the feature/add_functional_tests_for_docs branch December 20, 2021 12:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@l8556 l8556 l8556 approved these changes

@ShockwaveNN ShockwaveNN ShockwaveNN approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@askonev @ShockwaveNN @l8556