Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using symbol __unix__ to improve portability #100

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

vtamara
Copy link
Contributor

@vtamara vtamara commented Aug 28, 2018

Replaces #66

@vtamara vtamara force-pushed the feature/portable_symbol_unix branch 2 times, most recently from 7f3c218 to 1a045d6 Compare August 28, 2018 10:14
@ShockwaveNN
Copy link
Contributor

Sorry for late response.
According to https://stackoverflow.com/questions/7063303/macro-unix-not-defined-in-macos-x
__unix__ is not available on MacOSX and iOS, so we think it may cause trouble in some cases for your changes (in some of changed lines - there is already check for macos, but I think not at all cases)

@lugeluge
Copy link

lugeluge commented Aug 8, 2019

This project is great. I wonder if I can compile it on vs2017?

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants