Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FreeBSD code updates in order to get core module compiling under it #660

Open
wants to merge 13 commits into
base: master
Choose a base branch
from
Open

FreeBSD code updates in order to get core module compiling under it #660

wants to merge 13 commits into from

Conversation

Teetoow
Copy link

@Teetoow Teetoow commented Jul 19, 2021

I updated my patch with the latest version of this module in order to get DocumentServer compiling and working under FreeBSD.
Please note that this pull request contains different patches :

  • most of them are preproc conditions (or qmake conditions) specific to FreeBSD: they won't impact other operating systems so they are really safe and can be integrated into your code without any trouble
  • several bugs have been corrected (FreeBSD compiler is really strict). Most of them are casting problem (wrong use of NULL)
  • one bug correction is related to the use of a V8 protected function. The public one needs the use of "isolate". Please check it.

Teetoow added 13 commits August 24, 2020 16:34
@Teetoow
Update source code and compilation files in order to get them compiling
b0e2888 
under FreeBSD
@Teetoow
Get the latest DocumentServer version
93aff48
@Teetoow
Add iconv library needed under FreeBSD
3cbba5e
@Teetoow
Since V8 build tools are unavaible under FreeBSD it is not possible to
8852725 
use the officially V8 sources build with the DocumentServer scrit. A
workaround is to use FreeBSD ports to get V8
@Teetoow
Iconv library is needed by docbuilder
c145076
@Teetoow
1. Add FreeBSD preproc command in order to load the correct header files
3f7f5b7 
2. Add a specific FreeBSD routine in order to get the correct path of
   binary which corresponds to the current running process
@Teetoow
Bug correction: a bool function cannot returns NULL.
221e1fd
@Teetoow
Add FreeBSD preproc in order to load the correct header files
013647a
@Teetoow
Add FreeBSD preproc conditions in order to load the correct FreeBSD
ad83d6c 
heaer files
@Teetoow
Bug correction: v8::ObjectTemplate::New() is a protected function whi…
ceff938 
…ch cannot be

executed in this scope. "isolate" argument might correct the bug
@Teetoow
Bug correction: pData is a char*& argument so this line is a bug. I
3976353 
guess that you wanted to reset the pointer so using "*" is wrong. If you
want to reset the data buffer content you might first check that pData
is not equal to NULL and then do: "*pData = (char)0;". NULL is
equivalent to a pointer (its cast is void*) not a byte nor a char.
@Teetoow
Add preproc condition in order to load the FreeBSD header files
7d77b3a
@Teetoow
This is a commit error: this code has been set twice
8cd53bc
@CLAassistant
Copy link

CLAassistant commented Jul 19, 2021 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Teetoow @CLAassistant