Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid early loading through the filesystem app type #511

Merged

Conversation

juliusknorr
Copy link
Contributor

This resolves an issue where rendering an error page could have caused to setup the Nextcloud filesystem which then pulls in the ONLYOFFICE app due to the defined filesystem app type. By itself this is not an issue, but in combination with using LDAP as a user backend

Steps to reproduce:

  • setup ldap
  • limit ONLYOFFICE to a local and an LDAP group
  • Enable the guests app
  • Remove the "text" app from the guests whitelist and add "ONLYOFFICE" to it
  • Share a folder as a regular user to a guest
  • Login as the guest
  • The guest triggers the loading of the text/workspace request which is blocked by the guest app

Before:

  • The ONLYOFFICE app will check the setup group limitation and will remove the LDAP group as the ldap user backend is not setup yet

After:

  • The ONLYOFFICE app is not loaded that early and will keep the group setting in place

Signed-off-by: Julius Härtl <jus@bitgrid.net>
@CLAassistant
Copy link

CLAassistant commented Aug 24, 2021

CLA assistant check
All committers have signed the CLA.

@LinneyS LinneyS changed the base branch from master to develop October 26, 2021 11:05
@LinneyS LinneyS merged commit 91ddf39 into ONLYOFFICE:develop Oct 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants