Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

connect hook to register #566

Merged
merged 1 commit into from
Jan 20, 2022
Merged

connect hook to register #566

merged 1 commit into from
Jan 20, 2022

Conversation

Antipkin-A
Copy link
Contributor

Changed method for connect hook

Copy link
Contributor

@julien-nc julien-nc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I confirm it solves the sync issue on NC 21 and 22. Hooks are now actually triggered and documents are downloaded again if some file changes were pushed from a client.

It does not affect NC 23 for which it was already working fine.

Copy link
Contributor

@juliusknorr juliusknorr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also makes sense from a conceptual perspective in how the register and boot methods are caleld during Nextcloud application bootstrap.

@djtilo-ol
Copy link

djtilo-ol commented Dec 16, 2021

"eneiluj"
It does not affect NC 23 for which it was already working fine.

I installed a fresh NextCloud 23 on my webspace and am sorry to say that the identical issue as in NC22 remains. Synced updates to documents (Office & PDF) are not recognized and an older version is shown.
The plugin is version 7.2.1 & I downloaded the latest NC 23.0.0, OO 6.4.2.
Regards
not syncing in nc23

@julien-nc
Copy link
Contributor

@djtilo-ol Thanks for the feedback. Have you tried to apply this patch to check if it actually fixes the issue in NC 23?

@djtilo-ol
Copy link

Hi, I can do that, sure. I am an ambitious rookie, but I can't quite make out what I have to alter in the file application.php as mentioned here
Can I download a patched file somewhere?

@julien-nc
Copy link
Contributor

You can see the diff in the Files changed tab right here.
Or here is a link to the raw file from this branch: https://github.com/ONLYOFFICE/onlyoffice-nextcloud/raw/6bcbce371dcd1ebad02ce68b2454fd6346a046ce/appinfo/application.php

@djtilo-ol
Copy link

This fixes the issue in NC22 and NC23 - outstanding & thank you
nc22 file sync
nc23 file sync
!

@julien-nc
Copy link
Contributor

@djtilo-ol And thank you for the feedback!

@djtilo-ol
Copy link

:) With your help I was able to send the patched file to our NC provider who added it for us, so that the problem is resolved until the new connector is released - that is absolutely amazing! Merry Christmas, should you celebrate it.

@biva
Copy link

biva commented Dec 17, 2021

It works for me as well :)

@9e9d
Copy link

9e9d commented Dec 24, 2021

Could someone please explain how to patch Nextcloud-VM with ONLYOFFICE integrated. I can't find anything resembling the 'application.php' file.

@djtilo-ol
Copy link

Hi, in the NextCloud folder you find the application.php in
/apps/onlyoffice/appinfo
Regards

@9e9d
Copy link

9e9d commented Dec 24, 2021

Thanks, I had to discover how find the content off /var/www
Unfortunately still big issues, office files won't sync back to windws pc with nextcloud app, reverted to 3.36 even, still not. I reverted this ' fix' again and no w seens better, so weird

@djtilo-ol
Copy link

The issue discussed here was that OnlyOffice could not open the latest version once two or three alterations were made locally and synced to NextCloud.
I checked by comparing Hashes of the files, like a fingerprint if you want.
Checksum is an app for NextCloud which allows you to generate i.e. MD5 hash value, then compare to local file and so on. This way I detected that NC was doing its job properly and OO was having a hard time opening the latest version.

@9e9d
Copy link

9e9d commented Dec 25, 2021

There is some voodoo processing going on to make up for the lack of an an actual process to deal with these document updates. See also: nextcloud/documentserver_community#191 I had to manually add a cron job to get some sort of reliable behavior, unbelievable really.

@9e9d
Copy link

9e9d commented Dec 25, 2021

Not to mention there is another bug about onlyoffice just stalling for merely trying to check the previous versions.

@genofire genofire mentioned this pull request Jan 6, 2022
@LinneyS LinneyS force-pushed the feature/desktop-sync branch from 6bcbce3 to 137e70c Compare January 20, 2022 14:16
@LinneyS LinneyS merged commit 57ab1d6 into develop Jan 20, 2022
@LinneyS LinneyS deleted the feature/desktop-sync branch January 20, 2022 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants