Update Frames.jl

[tkrisnguyen]

Propose a solution to issue #532

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.13%. Comparing base (7e0323b) to head (4c65d72).
Report is 1 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #533      +/-   ##
==========================================
+ Coverage   85.11%   85.13%   +0.02%     
==========================================
  Files          45       45              
  Lines        1935     1938       +3     
==========================================
+ Hits         1647     1650       +3     
  Misses        288      288              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[mvanzulli]

Makes sense, maybe we can avoid using unicode for subindex as it ads an extra overhead with no much value. So can we just rename to use n1 and n2

[mvanzulli]

Note that we will always allocate a new node, so maybe we can so it only when the numeric types missmatch?

[tkrisnguyen]

If a new node is allocated as proposed, does the performance reduce? I don't know how to check wether the numeric types are mismatch. Please help me.

[mvanzulli]

Sure the cleanest way is to extract the types form Node object as it is parametric in the coords type:

julia> n2
• Node at [2, 3, 4] and dofs {}

julia> typeof(n2)
Node{3, Int64}

So we can use:

function Frame(n1::N1, n2::N2, g::G, mass_matrix::MassMatrix = Consistent,
        label::Label = NO_LABEL) where {dim, T1, T2, N1 <: AbstractNode{dim, T1},
        N2 <: AbstractNode{dim, T2}, G <: AbstractCrossSection}
    if T1 == T2
        Frame(SVector(n1, n2), g, mass_matrix, label)
    else
        temp = promote(n1.x, n2.x)
        n1r = Node(first(temp), n1.dofs)
        n2r = Node(last(temp), n2.dofs)
        Frame(SVector(n1r, n2r), g, mass_matrix, label)
    end
end

Next time it would be easier for me if you create this branch from your local desktop git https://github.com/apps/desktop if not I have to copy and paste your chages to reproduce what you did. I'm happy to help if u found any trouble with this.

[mvanzulli]

Minor: Can you add a test in frame.jl with this case just creating single element ?

[mvanzulli]

@tkrisnguyen are you planning to address this issue ? I'm happy to do a sync if that helps, if not I can try to merge it.