Bug - Building with node 10 #484
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Snyk is complaining about a transient dependency having a security vulnerability. But AFAICT they are not going to resolve it isaacs/chownr#14 So I think we should ignore this in synk. |
tgandrews
force-pushed
the
bug-building-node-10
branch
2 times, most recently
from
cc12ae5 to
ea15739
Compare
|
Is it worth updating the .nvmrc file to |
samiwel
approved these changes
Nov 19, 2018
There was a problem hiding this comment.
LGTM. Agree with @SamGodwin2's comment, but may as well make that change on the monorepo now?
Edit: actually could make the change here. It will be pulled down into the monorepo then.
tgandrews
force-pushed
the
bug-building-node-10
branch
from
ea15739 to
0b7312e
Compare
- Upgrade firebase as it had a dependency on an old version of grpc - Update travis to use node 10 - Update nvmrc to node 10 lts - Update docker to node 10 lts
tgandrews
force-pushed
the
bug-building-node-10
branch
from
0b7312e to
d87b33f
Compare
|
@samiwel @SamGodwin2 I updated the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the context of this PR?
Upgrade firebase which had the dependency on the old version of grpc which was failing to build on node 10.
How to review