Skip to content

Added run command in makefile #70

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
delterr wants to merge 3 commits into from
Closed

Added run command in makefile #70

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7f68f06
Added run command in makefile
delterr Sep 12, 2024
945856d
trying module name generalisation
delterr Sep 12, 2024
2f9ca75
Merge branch 'main' into makefile_run
sanjeevz3009 Sep 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,3 +37,7 @@ update-template-packages: ## Update the project using the initial copier templa
.PHONY: clean
clean: ## Clean the temporary files.
rm -rf megalinter-reports

.PHONY: run
run: ## Run the application
poetry run python {{module_name}}
Comment on lines +41 to +43
Copy link
Collaborator

@MebinAbraham MebinAbraham Oct 25, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR.

  1. This is the wrong file; you need to add this to https://github.com/ONSdigital/ons-python-template/blob/main/project_template/Makefile.jinja (templates makefile, not this repo's root template)

  2. You also need to make it agnostic to the package manager, so it should be:

{{ package_manager }} run python {{ module_name }}
  1. Please add this new __main__.py file to https://github.com/ONSdigital/ons-python-template#structure

8 changes: 8 additions & 0 deletions project_template/{{module_name}}/__main__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
from calculator import Calculator
calc = Calculator()

calc.add(5)

calc.subtract(2)

print(calc.cumulative_total)
Comment on lines +1 to +8
Copy link
Collaborator

@MebinAbraham MebinAbraham Oct 25, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This would currently raise lint failures.

Suggested change
from calculator import Calculator
calc = Calculator()
calc.add(5)
calc.subtract(2)
print(calc.cumulative_total)
from calculator import Calculator
calc = Calculator()
calc.add(5)
calc.subtract(2)
print(calc.cumulative_total)