Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OPS implementation for Fortran code of Laplace #174

Merged
merged 8 commits into from
Aug 10, 2022

Conversation

Ashutosh-Londhe
Copy link
Collaborator

Added Fortran implementation of Laplace
Implemented OPS version on Laplace Fortran code

@gihanmudalige
Copy link
Collaborator

@Ashutosh-Londhe does the code generator work on this ? Does it produce the different parallel versions ?

@Ashutosh-Londhe
Copy link
Collaborator Author

@Ashutosh-Londhe does the code generator work on this ? Does it produce the different parallel versions ?

Code generator able to generate following executables

  1. laplace_seq
  2. laplace_mpi
  3. laplace_openmp
  4. laplace_mpi_openmp
  5. laplace_cuda
  6. laplace_mpi_cuda

All above mentioned able to generate correct output

@reguly
Copy link
Collaborator

reguly commented Aug 9, 2022

So far so good. Please add the intermediate steps too - although ops_par_loops will require code generation to compile. However, it will be very interesting and important to see how we can gradually move an application to use OPS, loop by loop.

@gihanmudalige
Copy link
Collaborator

I think this is good for getting an initial understanding of the Fortran API and checking if the backend is working. However I agree with @reguly that it would be important to add the intermediate steps to elaborate on the conversion process. Our colleagues at Uni of Newcastle might like to see this, given they will do a bit chunk of the SENGA+ conversion. So lets plan to add this intermediate steps later down the line. I will approve this PR based on this.

@gihanmudalige
Copy link
Collaborator

I think we are ok to merge this. @reguly if you are ok then do approve. I think we can add the other middle steps a bit later as currently @Ashutosh-Londhe is getting up to speed with OPS and we need to start working on SENGA+

@gihanmudalige gihanmudalige merged commit 226e549 into develop Aug 10, 2022
@Ashutosh-Londhe Ashutosh-Londhe deleted the ops_laplace_fortran branch April 6, 2023 18:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants