replaced url package with URL constructor #166
+6
−27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Does this run in React Native? |
|
Good question. Also, I think it is still a good idea to eliminate as many dependencies as possible for the web, reduce the bundle size, follow the standards as much as possible, make the polyfills optional, and use them where we actually need them. |
|
I will keep this open but not merge it, maybe some time in the future. No need to break what is working for the sake of only one platform. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR solved #149 by replacing
urldependency with the native URL() constructor.This constructor supports by Node.js since v6.13 https://developer.mozilla.org/en-US/docs/Web/API/URL/URL
The minimum Node.js version is 18 according to package.json requirements.