Prepare/1.8.4 #1010
Merged
Prepare/1.8.4 #1010
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
They have currently no effect, as the service they call does not exist, and they are also incomplete. They cause errors with ph-schematron 8.0.0 in pure mode, so it's better to remove them. (cherry picked from commit e9d516d)
Remove assert that checks that BT-1118-NoticeResult is the sum of the values for each lot. Also remove corresponding Schematron rule, update affected validation reports (removal of a fired rule). (cherry picked from commit ccf7a7c)
(cherry picked from commit 53b7711)
Correct the message to match the rule in place (0 to 60 days). Other languages are correct. Fixes issue #980.
Winner Decision (BT-1451) can be on the same day the notice is submitted (BT-05) and the contract is signed (BT-145). Also update corresponding Schematron rules. (cherry picked from commit d851252)
bertrand-lorentz
approved these changes
Sep 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.