Prepare release of version 1.13.0 #66
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also add the corresponding NTDs in the unit test data.
Add voluntary forms to expected notice subtypes (TEDEFO-3556)
Also update to the latest version.
This plugin seems to only use the maven.compiler.source property.
Doing this in Drools causes very high memory usage (over 5GB) when run on the SDK, probably because of the high number of asserts.
Add more checks on schematron files
Log errors and warning after each validator is run, to know earlier when problems are found. Move the slowest validator (EFX) to the end to not delay the others. The complete list of warnings and errors is still logged at the end, as it was before, to get everyting in one place.
Output validation results earlier (TEDEFO-3685)
We need the bugfixes included in that version.
Use JMH to run the Schematron rules of the SDK being analyzed against a set of large XML notices, and write the results to a JSON file. This allows detecting when a change in the rules makes them slower, by comparing with results from another run. The notices used in the benchmark are included as resources, as we need them to be always the same, and to be large enough to make slowdowns noticeable. So we can't use the notice examples from the SDK being analyzed.
Add a validation error instead of failing with a NullPointerException.
XmlSchemaValidator: Handle element not found in the schema (TEDEFO-3707)
Add a benchmark for schematron rules
These dependencies are not optional, they are used by all features. They are included in the full/shaded JAR with all other dependencies anyways.
It's a dependency of drools-ruleunits-engine, and we don't use anything from it directly, so we don't need to have it in our pom.
Don't replace the original JAR with the full/shaded JAR, but create the full JAR with the "-all" suffix.
It's is set to the default value, so we actually don't need to specify it.
Publish packages to Maven Central
Use a notice with more lots for subtype 16, so that any slowdown is more noticeable. Update both notices to SDK 1.13.0, and fix most validation failures.
benchmark: Update notices used in the benchmark
|
Merging without review, as individual changes went through PRs, and this has been tested by checking the current SDK. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.