drivers: stm32_stgen: fix type in debug trace #7242
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jforissier
reviewed
Jan 24, 2025
...or what about using |
etienne-lms
reviewed
Jan 27, 2025
core/drivers/counter/stm32_stgen.c
Outdated
| @@ -155,7 +155,7 @@ static void stm32_stgen_pm_resume(void) | |||
| io_setbits32(stgen_d.base + STGENC_CNTCR, STGENC_CNTCR_EN); | |||
|
|
|||
| DMSG("Time spent in low-power: %"PRIu64"ms", | |||
| (nb_pm_count_ticks * 1000) / clock_src_rate); | |||
| (uint64_t)(nb_pm_count_ticks * 1000) / clock_src_rate); | |||
There was a problem hiding this comment.
nb_pm_count_ticks is of type signed long long so the DMSG() format specifier should be lld instead of "PRIu64".
There was a problem hiding this comment.
Oops, I didn't see Jérôme's comment :-)
|
Ok, fair, comment addressed (tag not applied) |
|
|
Fix the type in a debug trace in stm32_stgen_pm_resume() to fix a compilation warning. Fixes: b0b019b ("drivers: counter: stm32_stgen: add STGEN driver") Signed-off-by: Gatien Chevallier <gatien.chevallier@foss.st.com> Reviewed-by: Etienne Carriere <etienne.carriere@foss.st.com>
|
Tag applied, thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cast the result of an operation in stm32_stgen_pm_resume() to fix a compilation warning.