Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

xtest: add -DOPENSSL_API_COMPAT=10100 #689

Merged
merged 2 commits into from
Aug 3, 2023

Conversation

jforissier
Copy link
Contributor

regression_1000.c uses OpenSSL functions that have been deprecated after version 1.1. In particular, building with version 3.0 causes the following error (and other similar ones not pasted here):

optee_test/host/xtest/regression_1000.c: In function 'check_signature':
optee_test/host/xtest/regression_1000.c:2735:9: error: 'SHA256_Init' is deprecated: Since OpenSSL 3.0 [-Werror=deprecated-declarations]
2735 | SHA256_Init(&ctx);
| ^~~~~~~~~~~

Add -DOPENSSL_API_COMPAT=10100 to the build flags to avoid this and be flexible with regards to which version of OpenSSL build environment has to provide.

@jforissier jforissier mentioned this pull request Jul 25, 2023
@jenswi-linaro
Copy link
Contributor

Acked-by: Jens Wiklander <jens.wiklander@linaro.org>

regression_1000.c uses OpenSSL functions that have been deprecated
after version 1.1. In particular, building with version 3.0 causes the
following error (and other similar ones not pasted here):

 optee_test/host/xtest/regression_1000.c: In function 'check_signature':
 optee_test/host/xtest/regression_1000.c:2735:9: error: 'SHA256_Init' is deprecated: Since OpenSSL 3.0 [-Werror=deprecated-declarations]
  2735 |         SHA256_Init(&ctx);
       |         ^~~~~~~~~~~

Add -DOPENSSL_API_COMPAT=10100 to the build flags to avoid this and be
flexible with regards to which version of OpenSSL build environment has
to provide.

Signed-off-by: Jerome Forissier <jerome.forissier@linaro.org>
Acked-by: Jens Wiklander <jens.wiklander@linaro.org>
Removes the embedded binary copy of OpenSSL. The library is instead
expected to be found in the build environment which might be native or
cross compilation.

Signed-off-by: Jens Wiklander <jens.wiklander@linaro.org>
Acked-by: Jerome Forissier <jerome.forissier@linaro.org>
Acked-by: Clement Faure <clement.faure@nxp.com>
@jforissier jforissier merged commit f4dd113 into OP-TEE:master Aug 3, 2023
1 check passed
@jforissier jforissier deleted the openssl-1.1-compat branch August 3, 2023 19:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants