Update packages performance upgrade #88
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix test files that were broken by accident
Add other dependencies that were missing to get configuration to work correctly. Does Not Run Correctly. Changes were made to Core Stack/Opc.Ua.Core/Types/BuiltIn/NodeId.cs June 2023 that changes the Parse of the NodeId. Previously, it would return Null in the case that a parse couldn't happen, now an exception takes place. ModelManager does not handle the exception, so the system fails, presumably a lot.
Opc.Ua.Core NodeId InternalParse now throw exceptions when unsuccessfully creating a nodeId, causing severe slowdown in performance.
JimLuth
approved these changes
Jan 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OPCFoundation.NetStandard.Opc.Ua v 1.4.371.60 had vulnerabilities, so upgraded to use current version of 1.5.374.158.
Builtin type NodeId Parse from text now throws exceptions instead of returning null. This caused a large increase in conversion time.
Found problem area in AddModifyAttribute, and removed the FindNode, as it never succeeded in all test cases.