Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Console Reference Client] Durable Subscription Implementation #2738

Conversation

Archie-Miller
Copy link
Contributor

@Archie-Miller Archie-Miller commented Aug 26, 2024

Proposed changes

Implement a helper method in Opc.Ua.Client.Subscription that calls the Server SetSubscriptionDurable method.

In the ConsoleReferenceClient, Implement a sample implementation that shows the functionality of SetSubscriptionDurable from the client's perspective of pausing a subscription, then creating a new session and subscription and after transfer, retrieve all values with loosing any.

Also in ConsoleReferenceClient, allow for the retrieval of event data, with and without Durable Subscriptions.

Related Issues

https://github.com/orgs/OPCFoundation/projects/1/views/18 Task 1 - Addfunctionto client SDK to support SetSubscriptionDurable

Types of changes

What types of changes does your code introduce?
Put an x in the boxes that apply. You can also fill these out after creating the PR.

  • Bugfix (non-breaking change which fixes an issue)
  • Enhancement (non-breaking change which adds functionality)
  • Test enhancement (non-breaking change to increase test coverage)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected, requires version increase of Nuget packages)
  • Documentation Update (if none of the other choices apply)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have read the CONTRIBUTING doc.
  • I have signed the CLA.
  • I ran tests locally with my changes, all passed.
  • I fixed all failing tests in the CI pipelines.
  • I fixed all introduced issues with CodeQL and LGTM.
  • I have added tests that prove my fix is effective or that my feature works and increased code coverage.
  • I have added necessary documentation (if appropriate).
  • Any dependent changes have been merged and published in downstream modules.

Further comments

Copy link

codecov bot commented Aug 26, 2024

Codecov Report

Attention: Patch coverage is 70.00000% with 12 lines in your changes missing coverage. Please review.

Project coverage is 54.90%. Comparing base (41363bd) to head (9fedb96).
Report is 24 commits behind head on develop/durable.

Files with missing lines Patch % Lines
...braries/Opc.Ua.Client/Subscription/Subscription.cs 70.00% 12 Missing ⚠️
Additional details and impacted files
@@                 Coverage Diff                 @@
##           develop/durable    #2738      +/-   ##
===================================================
- Coverage            55.16%   54.90%   -0.27%     
===================================================
  Files                  349      349              
  Lines                65694    66082     +388     
  Branches             13440    13551     +111     
===================================================
+ Hits                 36239    36280      +41     
- Misses               25618    25865     +247     
- Partials              3837     3937     +100     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@romanett romanett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works good in my tests with both server supporting durable & servers that don't

Applications/ConsoleReferenceClient/ClientSamples.cs Outdated Show resolved Hide resolved
Applications/ConsoleReferenceClient/UAClient.cs Outdated Show resolved Hide resolved
Applications/ConsoleReferenceClient/UAClient.cs Outdated Show resolved Hide resolved
@romanett romanett added this to the Oktober Update milestone Aug 28, 2024
@romanett romanett changed the base branch from master to develop/durable October 13, 2024 13:35
@romanett romanett changed the title Rebuild Sample Client Durable Subscription Implementation [Console Reference Client] Durable Subscription Implementation Oct 13, 2024
@mregen mregen merged commit d2b4aa2 into OPCFoundation:develop/durable Oct 18, 2024
73 of 74 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants