-
Notifications
You must be signed in to change notification settings - Fork 961
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Console Reference Client] Durable Subscription Implementation #2738
[Console Reference Client] Durable Subscription Implementation #2738
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop/durable #2738 +/- ##
===================================================
- Coverage 55.16% 54.90% -0.27%
===================================================
Files 349 349
Lines 65694 66082 +388
Branches 13440 13551 +111
===================================================
+ Hits 36239 36280 +41
- Misses 25618 25865 +247
- Partials 3837 3937 +100 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
works good in my tests with both server supporting durable & servers that don't
Proposed changes
Implement a helper method in Opc.Ua.Client.Subscription that calls the Server SetSubscriptionDurable method.
In the ConsoleReferenceClient, Implement a sample implementation that shows the functionality of SetSubscriptionDurable from the client's perspective of pausing a subscription, then creating a new session and subscription and after transfer, retrieve all values with loosing any.
Also in ConsoleReferenceClient, allow for the retrieval of event data, with and without Durable Subscriptions.
Related Issues
https://github.com/orgs/OPCFoundation/projects/1/views/18 Task 1 - Addfunctionto client SDK to support SetSubscriptionDurable
Types of changes
What types of changes does your code introduce?
Put an
x
in the boxes that apply. You can also fill these out after creating the PR.Checklist
Put an
x
in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.Further comments