Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SetHiResClockDisabled & fix Rejected Store Creation in ApplicationConfigurationBuilder #2909

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

romanett
Copy link
Contributor

@romanett romanett commented Dec 15, 2024

Proposed changes

Add the method SetHiResClockDisabled to IApplicationConfigurationBuilder

Fix the type of RejectedStore Created by the Builder to: CertificateStoreIdentifier

Related Issues

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • Enhancement (non-breaking change which adds functionality)
  • Test enhancement (non-breaking change to increase test coverage)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected, requires version increase of Nuget packages)
  • Documentation Update (if none of the other choices apply)

Checklist

  • I have read the CONTRIBUTING doc.
  • I have signed the CLA.
  • I ran tests locally with my changes, all passed.
  • I fixed all failing tests in the CI pipelines.
  • I fixed all introduced issues with CodeQL and LGTM.
  • I have added tests that prove my fix is effective or that my feature works and increased code coverage.
  • I have added necessary documentation (if appropriate).
  • Any dependent changes have been merged and published in downstream modules.

@romanett romanett self-assigned this Dec 15, 2024
Copy link

codecov bot commented Dec 15, 2024

Codecov Report

Attention: Patch coverage is 60.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 46.13%. Comparing base (c87eca9) to head (894965c).

Files with missing lines Patch % Lines
...a.Configuration/ApplicationConfigurationBuilder.cs 60.00% 2 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (c87eca9) and HEAD (894965c). Click for more details.

HEAD has 11 uploads less than BASE
Flag BASE (c87eca9) HEAD (894965c)
24 13
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2909      +/-   ##
==========================================
- Coverage   55.37%   46.13%   -9.25%     
==========================================
  Files         352      352              
  Lines       67602    67604       +2     
  Branches    13849    13849              
==========================================
- Hits        37437    31190    -6247     
- Misses      26059    32639    +6580     
+ Partials     4106     3775     -331     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@romanett romanett changed the title Add DisableHiResClock to ApplicationConfigurationBuilder Add SetHiResClockDisabled & fix Rejected Store Creation in ApplicationConfigurationBuilder Dec 16, 2024
@romanett romanett added this to the 1.5.375 ECC official release milestone Dec 16, 2024
@romanett romanett requested a review from mregen December 16, 2024 14:43
@romanett romanett added the bug A bug was identified and should be fixed. label Dec 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug A bug was identified and should be fixed.
Projects
None yet
2 participants