Update to .Net 9.0 #215
Merged
Update to .Net 9.0 #215
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ror due to depricated APIs and fixed all warnings (use specific types instead of var, usings consistently declared outside of namespaces, inline arrays declared as class members, class naming conventions, marking internal classes as sealed where possible, don't use .Any() for perf)
Closed
|
@MarkusHorstmann, welcome back :-) Just kidding... Please also have a look at the failed unit tests. |
There was a problem hiding this comment.
Copilot reviewed 97 out of 112 changed files in this pull request and generated no comments.
Files not reviewed (15)
- CloudLibSync/CloudLibSync.csproj: Language not supported
- CloudLibSyncAzureFunction/CloudLibSyncAzureFunction.csproj: Language not supported
- Opc.Ua.CloudLib.Client/Opc.Ua.Cloud.Library.Client.csproj: Language not supported
- Opc.Ua.CloudLib.Client/GraphQlExtensions.cs: Evaluated as low risk
- Opc.Ua.CloudLib.Client/Models/VariableResult.cs: Evaluated as low risk
- Opc.Ua.CloudLib.Client/Models/UANodesetResult.cs: Evaluated as low risk
- Opc.Ua.CloudLib.Client/Models/ObjectResult.cs: Evaluated as low risk
- Opc.Ua.CloudLib.Client/Models/ReferenceResult.cs: Evaluated as low risk
- Opc.Ua.CloudLib.Client/Models/DataResult.cs: Evaluated as low risk
- Opc.Ua.CloudLib.Client/Models/MetadataResult.cs: Evaluated as low risk
- Opc.Ua.CloudLib.Client/Models/UANameSpace.cs: Evaluated as low risk
- Opc.Ua.CloudLib.Client/Models/NodeResult.cs: Evaluated as low risk
- Opc.Ua.CloudLib.Client/Models/GraphQLNodeSet.cs: Evaluated as low risk
- Opc.Ua.CloudLib.Client/RestClient.cs: Evaluated as low risk
- .github/workflows/dotnet.yml: Evaluated as low risk
Comments suppressed due to low confidence (5)
CloudLibSyncAzureFunction/CloudSyncFunction.cs:42
- [nitpick] The variable name 'error' is ambiguous. It should be renamed to something more descriptive like 'optionError'.
string error = nameof(CloudLibSyncOptions);
CloudLibSyncAzureFunction/CloudSyncFunction.cs:47
- [nitpick] The variable name 'error' is ambiguous. It should be renamed to something more descriptive like 'sourceError'.
string error = nameof(options.Value.Source);
CloudLibSyncAzureFunction/CloudSyncFunction.cs:52
- [nitpick] The variable name 'error' is ambiguous. It should be renamed to something more descriptive like 'targetError'.
string error = nameof(options.Value.Target);
CloudLibSync/CloudLibSync.cs:44
- The use of nullable type GraphQlNodeAndCursor? seems unnecessary here since nodeSetResult.Edges should not contain null entries. Change to foreach (GraphQlNodeAndCursor nodeSetAndCursor in nodeSetResult.Edges).
foreach (GraphQlNodeAndCursor<Nodeset>? nodeSetAndCursor in nodeSetResult.Edges)
CloudLibSync/CloudLibSync.cs:136
- The use of nullable type Nodeset? seems unnecessary here since toSync should not contain null entries. Change to foreach (Nodeset nodeSet in toSync).
foreach (Nodeset? nodeSet in toSync)
There was a problem hiding this comment.
Copilot reviewed 97 out of 112 changed files in this pull request and generated no comments.
Files not reviewed (15)
- CloudLibSync/CloudLibSync.csproj: Language not supported
- CloudLibSyncAzureFunction/CloudLibSyncAzureFunction.csproj: Language not supported
- Opc.Ua.CloudLib.Client/Opc.Ua.Cloud.Library.Client.csproj: Language not supported
- Opc.Ua.CloudLib.Client/Models/NodeResult.cs: Evaluated as low risk
- Opc.Ua.CloudLib.Client/Models/ObjectResult.cs: Evaluated as low risk
- Opc.Ua.CloudLib.Client/GraphQlExtensions.cs: Evaluated as low risk
- Opc.Ua.CloudLib.Client/Models/VariableResult.cs: Evaluated as low risk
- Opc.Ua.CloudLib.Client/Models/UANodesetResult.cs: Evaluated as low risk
- Opc.Ua.CloudLib.Client/Models/MetadataResult.cs: Evaluated as low risk
- Opc.Ua.CloudLib.Client/Models/DataResult.cs: Evaluated as low risk
- Opc.Ua.CloudLib.Client/Models/UANameSpace.cs: Evaluated as low risk
- Opc.Ua.CloudLib.Client/Models/ReferenceResult.cs: Evaluated as low risk
- Opc.Ua.CloudLib.Client/RestClient.cs: Evaluated as low risk
- Opc.Ua.CloudLib.Client/Models/GraphQLNodeSet.cs: Evaluated as low risk
- .github/workflows/dotnet.yml: Evaluated as low risk
PaulLinYao
approved these changes
Jan 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.