Bad rpath added to build_dmrpp - not portable linkage

[opoplawski]

I'm looking to update the Fedora bes package to 3.20.10 but am running into the following issue:

+ /usr/lib/rpm/check-rpaths
*******************************************************************************
*
* WARNING: 'check-rpaths' detected a broken RPATH OR RUNPATH and will cause
*          'rpmbuild' to fail. To ignore these errors, you can set the
*          '$QA_RPATHS' environment variable which is a bitmask allowing the
*          values below. The current value of QA_RPATHS is 0x0000.
*
*    0x0001 ... standard RPATHs (e.g. /usr/lib); such RPATHs are a minor
*               issue but are introducing redundant searchpaths without
*               providing a benefit. They can also cause errors in multilib
*               environments.
*    0x0002 ... invalid RPATHs; these are RPATHs which are neither absolute
*               nor relative filenames and can therefore be a SECURITY risk
*    0x0004 ... insecure RPATHs; these are relative RPATHs which are a
*               SECURITY risk
*    0x0008 ... the special '$ORIGIN' RPATHs are appearing after other
*               RPATHs; this is just a minor issue but usually unwanted
*    0x0010 ... the RPATH is empty; there is no reason for such RPATHs
*               and they cause unneeded work while loading libraries
*    0x0020 ... an RPATH references '..' of an absolute path; this will break
*               the functionality when the path before '..' is a symlink
*          
*
* Examples:
* - to ignore standard and empty RPATHs, execute 'rpmbuild' like
*   $ QA_RPATHS=$(( 0x0001|0x0010 )) rpmbuild my-package.src.rpm
* - to check existing files, set $RPM_BUILD_ROOT and execute check-rpaths like
*   $ RPM_BUILD_ROOT=<top-dir> /usr/lib/rpm/check-rpaths
*  
*******************************************************************************
ERROR   0002: file '/usr/bin/build_dmrpp' contains an invalid  '/builddir/build/BUILD/bes-3.20.10/dap/.libs' in [/builddir/build/BUILD/bes-3.20.10/dap/.libs:/builddir/build/BUILD/bes-3.20.10/dispatch/.libs:/usr/lib64/bes]
ERROR   0002: file '/usr/bin/build_dmrpp' contains an invalid  '/builddir/build/BUILD/bes-3.20.10/dispatch/.libs' in [/builddir/build/BUILD/bes-3.20.10/dap/.libs:/builddir/build/BUILD/bes-3.20.10/dispatch/.libs:/usr/lib64/bes]

This appears to arise due to build_drmpp being linked to a module:

make[4]: Entering directory '/builddir/build/BUILD/bes-3.20.10/modules/dmrpp_module'
/bin/sh ../../libtool  --tag=CXX   --mode=link g++ -Wno-vla-extension -Wno-inconsistent-missing-override  -g -O2 --pedantic --std=c++11 -L../../dap -static -ldap_module -dynamic -L/usr/lib64/libdap -o build_dmrpp build_dmrpp-DMRpp.o build_dmrpp-DmrppCommon.o build_dmrpp-Chunk.o build_dmrpp-CurlHandlePool.o build_dmrpp-DmrppByte.o build_dmrpp-DmrppArray.o build_dmrpp-DmrppFloat32.o build_dmrpp-DmrppFloat64.o build_dmrpp-DmrppInt16.o build_dmrpp-DmrppInt32.o build_dmrpp-DmrppInt64.o build_dmrpp-DmrppInt8.o build_dmrpp-DmrppUInt16.o build_dmrpp-DmrppUInt32.o build_dmrpp-DmrppUInt64.o build_dmrpp-DmrppStr.o build_dmrpp-DmrppStructure.o build_dmrpp-DmrppUrl.o build_dmrpp-DmrppD4Enum.o build_dmrpp-DmrppD4Group.o build_dmrpp-DmrppD4Opaque.o build_dmrpp-DmrppD4Sequence.o build_dmrpp-DmrppTypeFactory.o build_dmrpp-DmrppParserSax2.o build_dmrpp-DmrppMetadataStore.o build_dmrpp-CredentialsManager.o build_dmrpp-AccessCredentials.o build_dmrpp-NgapS3Credentials.o build_dmrpp-SuperChunk.o build_dmrpp-awsv4.o build_dmrpp-DMZ.o  build_dmrpp-DmrppRequestHandler.o build_dmrpp-build_dmrpp.o build_dmrpp-h5common.o -L../../dispatch -lbes_dispatch -L../../http -lbes_http -lcurl -luuid -ltirpc  -L. -lhdf5 -ldl -ldapserver -ldap  -ldapclient -ldap  -L/usr/local/opt/openssl/lib -lcrypto -lxml2   -lz -lcurl -luuid -ltirpc
*** Warning: Linking the executable build_dmrpp against the loadable module
*** libdap_module.so is not portable!
libtool: link: g++ -Wno-vla-extension -Wno-inconsistent-missing-override -g -O2 --pedantic --std=c++11 -dynamic -o build_dmrpp build_dmrpp-DMRpp.o build_dmrpp-DmrppCommon.o build_dmrpp-Chunk.o build_dmrpp-CurlHandlePool.o build_dmrpp-DmrppByte.o build_dmrpp-DmrppArray.o build_dmrpp-DmrppFloat32.o build_dmrpp-DmrppFloat64.o build_dmrpp-DmrppInt16.o build_dmrpp-DmrppInt32.o build_dmrpp-DmrppInt64.o build_dmrpp-DmrppInt8.o build_dmrpp-DmrppUInt16.o build_dmrpp-DmrppUInt32.o build_dmrpp-DmrppUInt64.o build_dmrpp-DmrppStr.o build_dmrpp-DmrppStructure.o build_dmrpp-DmrppUrl.o build_dmrpp-DmrppD4Enum.o build_dmrpp-DmrppD4Group.o build_dmrpp-DmrppD4Opaque.o build_dmrpp-DmrppD4Sequence.o build_dmrpp-DmrppTypeFactory.o build_dmrpp-DmrppParserSax2.o build_dmrpp-DmrppMetadataStore.o build_dmrpp-CredentialsManager.o build_dmrpp-AccessCredentials.o build_dmrpp-NgapS3Credentials.o build_dmrpp-SuperChunk.o build_dmrpp-awsv4.o build_dmrpp-DMZ.o build_dmrpp-DmrppRequestHandler.o build_dmrpp-build_dmrpp.o build_dmrpp-h5common.o  -L../../dap /builddir/build/BUILD/bes-3.20.10/dap/.libs/libdap_module.so -L/usr/lib64/libdap -L../../dispatch /builddir/build/BUILD/bes-3.20.10/dispatch/.libs/libbes_dispatch.so -L../../http /builddir/build/BUILD/bes-3.20.10/http/.libs/libbes_http.a -L../dispatch ../../dispatch/.libs/libbes_dispatch.so -lbz2 -lpthread -L/usr/local/opt/openssl/lib -L. -lhdf5 -ldl -ldapserver -ldapclient -ldap -lcrypto -lxml2 -lz -lcurl -luuid -ltirpc -Wl,-rpath -Wl,/builddir/build/BUILD/bes-3.20.10/dap/.libs -Wl,-rpath -Wl,/builddir/build/BUILD/bes-3.20.10/dispatch/.libs -Wl,-rpath -Wl,/usr/lib64/bes
make[4]: Leaving directory '/builddir/build/BUILD/bes-3.20.10/modules/dmrpp_module'

which libtool notes is "not portable".

[jgallagher59701]

I think I know how to fix this - it’s been on my list to look into it for a while. Thanks for the report, James

On Jan 14, 2022, at 20:44, Orion Poplawski ***@***.***> wrote: I'm looking to update the Fedora bes package to 3.20.10 but am running into the following issue: + /usr/lib/rpm/check-rpaths ******************************************************************************* * * WARNING: 'check-rpaths' detected a broken RPATH OR RUNPATH and will cause * 'rpmbuild' to fail. To ignore these errors, you can set the * '$QA_RPATHS' environment variable which is a bitmask allowing the * values below. The current value of QA_RPATHS is 0x0000. * * 0x0001 ... standard RPATHs (e.g. /usr/lib); such RPATHs are a minor * issue but are introducing redundant searchpaths without * providing a benefit. They can also cause errors in multilib * environments. * 0x0002 ... invalid RPATHs; these are RPATHs which are neither absolute * nor relative filenames and can therefore be a SECURITY risk * 0x0004 ... insecure RPATHs; these are relative RPATHs which are a * SECURITY risk * 0x0008 ... the special '$ORIGIN' RPATHs are appearing after other * RPATHs; this is just a minor issue but usually unwanted * 0x0010 ... the RPATH is empty; there is no reason for such RPATHs * and they cause unneeded work while loading libraries * 0x0020 ... an RPATH references '..' of an absolute path; this will break * the functionality when the path before '..' is a symlink * * * Examples: * - to ignore standard and empty RPATHs, execute 'rpmbuild' like * $ QA_RPATHS=$(( 0x0001|0x0010 )) rpmbuild my-package.src.rpm * - to check existing files, set $RPM_BUILD_ROOT and execute check-rpaths like * $ RPM_BUILD_ROOT=<top-dir> /usr/lib/rpm/check-rpaths * ******************************************************************************* ERROR 0002: file '/usr/bin/build_dmrpp' contains an invalid '/builddir/build/BUILD/bes-3.20.10/dap/.libs' in [/builddir/build/BUILD/bes-3.20.10/dap/.libs:/builddir/build/BUILD/bes-3.20.10/dispatch/.libs:/usr/lib64/bes] ERROR 0002: file '/usr/bin/build_dmrpp' contains an invalid '/builddir/build/BUILD/bes-3.20.10/dispatch/.libs' in [/builddir/build/BUILD/bes-3.20.10/dap/.libs:/builddir/build/BUILD/bes-3.20.10/dispatch/.libs:/usr/lib64/bes] This appears to arise due to build_drmpp being linked to a module: make[4]: Entering directory '/builddir/build/BUILD/bes-3.20.10/modules/dmrpp_module' /bin/sh ../../libtool --tag=CXX --mode=link g++ -Wno-vla-extension -Wno-inconsistent-missing-override -g -O2 --pedantic --std=c++11 -L../../dap -static -ldap_module -dynamic -L/usr/lib64/libdap -o build_dmrpp build_dmrpp-DMRpp.o build_dmrpp-DmrppCommon.o build_dmrpp-Chunk.o build_dmrpp-CurlHandlePool.o build_dmrpp-DmrppByte.o build_dmrpp-DmrppArray.o build_dmrpp-DmrppFloat32.o build_dmrpp-DmrppFloat64.o build_dmrpp-DmrppInt16.o build_dmrpp-DmrppInt32.o build_dmrpp-DmrppInt64.o build_dmrpp-DmrppInt8.o build_dmrpp-DmrppUInt16.o build_dmrpp-DmrppUInt32.o build_dmrpp-DmrppUInt64.o build_dmrpp-DmrppStr.o build_dmrpp-DmrppStructure.o build_dmrpp-DmrppUrl.o build_dmrpp-DmrppD4Enum.o build_dmrpp-DmrppD4Group.o build_dmrpp-DmrppD4Opaque.o build_dmrpp-DmrppD4Sequence.o build_dmrpp-DmrppTypeFactory.o build_dmrpp-DmrppParserSax2.o build_dmrpp-DmrppMetadataStore.o build_dmrpp-CredentialsManager.o build_dmrpp-AccessCredentials.o build_dmrpp-NgapS3Credentials.o build_dmrpp-SuperChunk.o build_dmrpp-awsv4.o build_dmrpp-DMZ.o build_dmrpp-DmrppRequestHandler.o build_dmrpp-build_dmrpp.o build_dmrpp-h5common.o -L../../dispatch -lbes_dispatch -L../../http -lbes_http -lcurl -luuid -ltirpc -L. -lhdf5 -ldl -ldapserver -ldap -ldapclient -ldap -L/usr/local/opt/openssl/lib -lcrypto -lxml2 -lz -lcurl -luuid -ltirpc *** Warning: Linking the executable build_dmrpp against the loadable module *** libdap_module.so is not portable! libtool: link: g++ -Wno-vla-extension -Wno-inconsistent-missing-override -g -O2 --pedantic --std=c++11 -dynamic -o build_dmrpp build_dmrpp-DMRpp.o build_dmrpp-DmrppCommon.o build_dmrpp-Chunk.o build_dmrpp-CurlHandlePool.o build_dmrpp-DmrppByte.o build_dmrpp-DmrppArray.o build_dmrpp-DmrppFloat32.o build_dmrpp-DmrppFloat64.o build_dmrpp-DmrppInt16.o build_dmrpp-DmrppInt32.o build_dmrpp-DmrppInt64.o build_dmrpp-DmrppInt8.o build_dmrpp-DmrppUInt16.o build_dmrpp-DmrppUInt32.o build_dmrpp-DmrppUInt64.o build_dmrpp-DmrppStr.o build_dmrpp-DmrppStructure.o build_dmrpp-DmrppUrl.o build_dmrpp-DmrppD4Enum.o build_dmrpp-DmrppD4Group.o build_dmrpp-DmrppD4Opaque.o build_dmrpp-DmrppD4Sequence.o build_dmrpp-DmrppTypeFactory.o build_dmrpp-DmrppParserSax2.o build_dmrpp-DmrppMetadataStore.o build_dmrpp-CredentialsManager.o build_dmrpp-AccessCredentials.o build_dmrpp-NgapS3Credentials.o build_dmrpp-SuperChunk.o build_dmrpp-awsv4.o build_dmrpp-DMZ.o build_dmrpp-DmrppRequestHandler.o build_dmrpp-build_dmrpp.o build_dmrpp-h5common.o -L../../dap /builddir/build/BUILD/bes-3.20.10/dap/.libs/libdap_module.so -L/usr/lib64/libdap -L../../dispatch /builddir/build/BUILD/bes-3.20.10/dispatch/.libs/libbes_dispatch.so -L../../http /builddir/build/BUILD/bes-3.20.10/http/.libs/libbes_http.a -L../dispatch ../../dispatch/.libs/libbes_dispatch.so -lbz2 -lpthread -L/usr/local/opt/openssl/lib -L. -lhdf5 -ldl -ldapserver -ldapclient -ldap -lcrypto -lxml2 -lz -lcurl -luuid -ltirpc -Wl,-rpath -Wl,/builddir/build/BUILD/bes-3.20.10/dap/.libs -Wl,-rpath -Wl,/builddir/build/BUILD/bes-3.20.10/dispatch/.libs -Wl,-rpath -Wl,/usr/lib64/bes make[4]: Leaving directory '/builddir/build/BUILD/bes-3.20.10/modules/dmrpp_module' which libtool notes is "not portable". — Reply to this email directly, view it on GitHub <#565>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AB7Q4KSBJGUJVHZBI6ZQHH3UWDUQ5ANCNFSM5MALQYJQ>. Triage notifications on the go with GitHub Mobile for iOS <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android <https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>. You are receiving this because you are subscribed to this thread.

— James Gallagher ***@***.***