Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Memory usage: Use 4-byte float instead of 8-byte double for summary data #7415

Closed
magnesj opened this issue Feb 23, 2021 · 1 comment
Closed

Memory usage: Use 4-byte float instead of 8-byte double for summary data #7415

magnesj opened this issue Feb 23, 2021 · 1 comment
Labels
System Refactoring or build/test system issues. Code improvments not directly affecting the user.
Milestone
Maintenance 2022 ...

Comments

@magnesj
Copy link
Member

magnesj commented Feb 23, 2021

Data for summary vectors are stored as 4-byte floats in the UNSMRY file. For some reason, the interface for reading this data in libecl is using 8-byte double.
equinor/resdata#797

Import of summary data in opm-common is using 4-byte float
https://github.com/OPM/opm-common/blob/master/opm/io/eclipse/ESmry.hpp

Investigate and find solution for reducing the memory usage.
@magnesj magnesj added the System Refactoring or build/test system issues. Code improvments not directly affecting the user. label Feb 23, 2021
@magnesj magnesj added this to the Maintenance 2021 - Sprint 2 milestone Feb 23, 2021
magnesj added a commit that referenced this issue Feb 23, 2021
@magnesj
#7415 Memory usage: Use float for summary data values
7e3a234
@magnesj magnesj mentioned this issue Feb 23, 2021
Closed
magnesj added a commit that referenced this issue Feb 24, 2021
@magnesj
#7415 Memory usage: Use float for summary data values
72acfdc
@github-actions
Copy link
Contributor

github-actions bot commented May 2, 2021

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days.

@github-actions github-actions bot added the Stale label May 2, 2021
@magnesj magnesj removed the Stale label May 2, 2021
@magnesj magnesj closed this as completed Feb 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
System Refactoring or build/test system issues. Code improvments not directly affecting the user.
Projects
None yet
Milestone
Maintenance 2022 - Backlog
Development

Successfully merging a pull request may close this issue.

Memory usage: Use float for summary data values OPM/ResInsight
2 participants
@hhgs @magnesj