Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MemPacker: mark buffer const in unpacker functions #4189

Merged
merged 1 commit into from
Sep 11, 2024

Conversation

akva2
Copy link
Member

@akva2 akva2 commented Sep 11, 2024

This to quell various static analyzer warnings

@akva2
Copy link
Member Author

akva2 commented Sep 11, 2024

jenkins build this opm-simulators=5598 please

Copy link
Member

@bska bska left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very good–it's always better to be "const correct". I'll merge this and its downstream companion PR into the master branch.

@bska bska merged commit c7b70e2 into OPM:master Sep 11, 2024
1 check passed
@akva2 akva2 deleted the sca_mark_unpack_buffer_const branch September 11, 2024 11:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants