Prepare for Restarting Models With Segment Level UDQs #4224
Conversation
|
jenkins build this please |
bska
force-pushed
the
prepare-su-restart
branch
8 times, most recently
from
cb6293f
to
0ad2a83
Compare
|
jenkins build this please |
bska
force-pushed
the
prepare-su-restart
branch
2 times, most recently
from
69f33d3
to
1d9c11f
Compare
In particular
- Explicitly include some headers that will not be available
through transitive inclusion
- Remove some unneeded objects/helper functions
- Move helper functions into anonymous namespaces where
appropriate
- Re-sort #include statements
bska
force-pushed
the
prepare-su-restart
branch
from
1d9c11f
to
68fc2bd
Compare
| // as a general purpose implementation, but does its job for testing and | ||
| // pretty-pringing for debugging purposes. | ||
|
|
||
| std::ostream& operator<<( std::ostream& stream, const Rates& r ) { |
There was a problem hiding this comment.
These operators might be good to have somewhere for debugging, but I guess they are not used here. A little surprised though, I would think some tests would print objects like these upon failure?
There was a problem hiding this comment.
These operators might be good to have somewhere for debugging,
Maybe, but then they must be significantly amended to account for a lot of changes that have happened since they were introduced in commit b43461c (originally OPM/opm-output@084a233, PR OPM/opm-output#98) and never maintained.
I guess they are not used here.
Correct, they are not.
A little surprised though, I would think some tests would print objects like these upon failure?
That depends on how we write the test statements. Macros like BOOST_CHECK_EQUAL or BOOST_CHECK_LT require objects that can be converted to a character representation through operator<<(), but the more low-level test macros like BOOST_CHECK don't impost such requirements.
|
jenkins build this please |
|
PR approved and build check is green. I'll merge into master. |
In particular
#includestatements